Patch set 6:Code-Review +1

View Change

10 comments:

• Commit Message:

  • Patch Set #6, Line 7: SOC

    nit: I usually see SoC

  • Patch Set #6, Line 7: drivers/intel/fsp2_0: Make FSP_USE_REPO an SOC opt-in instead of list dependency

    Summary has 50 characters limit

    Can remove "instead of list dependency"

  • Patch Set #6, Line 10: ee

    Only one `e`

  • Patch Set #6, Line 11: prune

    typo: pr*o*ne

  • Patch Set #6, Line 13: is introducing

    Use the same tense as the commit summary: introduces

  • Patch Set #6, Line 14: g

    trailing `g`

• File src/soc/intel/Kconfig:

  • Patch Set #6, Line 53: "Use FSP Blobs from fsp submodule"

    This shouldn't have a prompt

  • Patch Set #6, Line 55: This SOC has FSP binaries living in 3rdparty/fsp.

    How about:

     Select this if the platform has FSP binaries are publicly available in 3rdparty/fsp.

• File src/soc/intel/cannonlake/Kconfig:

  • Patch Set #6, Line 68: select HAVE_INTEL_FSP_REPO

    You also could just use `if !SOC_INTEL_CANNONLAKE`

    Not sure if CannonLake just uses the CoffeeLake FSP package, or if it is not supported at all

• File src/soc/intel/xeon_sp/Kconfig:

  • Patch Set #6, Line 41: select HAVE_INTEL_FSP_REPO

    Um, I don't think so.

To view, visit change 37582. To unsubscribe, or for help writing mail filters, visit settings.