13 comments:
File src/mainboard/gigabyte/ga-z170x-gaming7/Kconfig:
Patch Set #2, Line 14: SUPERIO_ITE_IT8528E
You're better off selecting IT8728E, really. IT8528E is an EC for laptops and such.
config DEVICETREE
string
default "devicetree.cb"
That's the default
File src/mainboard/gigabyte/ga-z170x-gaming7/devicetree.cb:
[4] = 0, \
[5] = 0, \
Enable these
# SATA4 and SATA5 are located in the lower right corner
# of the board, but there is no connector for this
Smells like copypasta
Patch Set #2, Line 211: # Set params for PEG 0:1:0
Check schematics for PCIe port routing
Patch Set #2, Line 330: chip superio/nuvoton/nct6791d
Not at all!
File src/mainboard/gigabyte/ga-z170x-gaming7/dsdt.asl:
Patch Set #2, Line 34: // CPU
Please drop, it does not provide any value.
File src/mainboard/gigabyte/ga-z170x-gaming7/gma-mainboard.ads:
Patch Set #2, Line 26: ports : constant Port_List :=
The rest of Ada code is indented with three spaces
File src/mainboard/gigabyte/ga-z170x-gaming7/gpio.h:
This should be a gpio.c instead
Patch Set #2, Line 25: static const struct pad_config gpio_table[] = {
Are these correct?
File src/mainboard/gigabyte/ga-z170x-gaming7/hda_verb.c:
Patch Set #2, Line 37: /* Intel, SkylakeHDMI */
Add a blank line between codecs for clarity
File src/mainboard/gigabyte/ga-z170x-gaming7/include/gpio.h:
why two gpio.h ?
File src/mainboard/gigabyte/ga-z170x-gaming7/mainboard.c:
This should not be necessary at all for SKL.
To view, visit change 38920. To unsubscribe, or for help writing mail filters, visit settings.