Please don't use cammelcase. Most of the code looks very UEFI like.
6 comments:
File src/security/intel/stm/Kconfig:
Patch Set #1, Line 7: depends on (PLATFORM_USES_FSP2_0||PLATFORM_USES_FSP1_1||PLATFORM_USES_FSP1_0)
why do you need FSP for that?
Patch Set #1, Line 12: hex "mseg size"
if this is user configureable, what are good values?
Add help text
File src/security/intel/stm/StmPlatformResource.c:
Patch Set #1, Line 180: // Find max bus number and PCIEX length
remove commented code
File src/security/intel/stm/StmPlatformSmm.c:
Patch Set #1, Line 27: extern bool StmCheckStmImage(void *StmImage, uint32_t StmImageSize);
don't use extern
Patch Set #1, Line 38: int LoadStmImage(uint32_t mseg)
uintptr_t
Patch Set #1, Line 57: StmImageSize = cbfs_boot_load_file("stm.bin", MsegBase, StmBufferSize, CBFS_TYPE_RAW);
check for errors
To view, visit change 33234. To unsubscribe, or for help writing mail filters, visit settings.