View Change
1 comment:
Commit Message:
Patch Set #5, Line 7: volteer
should I submit it in a separate patch for volteer2 to keep it clean?
eh it's fine, they're the same thing.
maybe:
mb/google/volteer: Add gpio-keys ACPI node for pen eject
and then mention you added it to volteer & volteer2 here
To view, visit change 43764. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida3217a5b156320856ce3302c2623eba2230f28d
Gerrit-Change-Number: 43764
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Levin <levinale@google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Alex Levin <levinale@chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro@google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Thu, 23 Jul 2020 22:24:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alex Levin <levinale@google.com>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-MessageType: comment