Now use the full struct for most of LP GPIO because the old one breaks things.
11 comments:
File util/autoport/haswell.go:
Patch Set #11, Line 39: FormatInt32(refclk / 128 / (inteltool.IGD[0xc8254] >> 16))
This results in a division by zero on desktop boards.
Done
Patch Set #11, Line 109: File: "drivers/intel/gma/acpi/default_brightness_levels.asl",
FIXME: This is not necessary if the board doesn't have backlight
Comment added.
File util/autoport/lynxpoint.go:
A lot of this code (especially the GPIO stuff) is the same as bd82x6x. […]
Done
File util/autoport/lynxpoint.go:
Patch Set #10, Line 401: // the lid is open by default.
Please use consistent comments in generated code
Done
File util/autoport/lynxpoint.go:
DSDTDefine{
Key: "BRIGHTNESS_UP",
Value: "\\_SB.PCI0.GFX0.INCB",
},
DSDTDefine{
Key: "BRIGHTNESS_DOWN",
Value: "\\_SB.PCI0.GFX0.DECB",
},
DSDTDefine{
Key: "ACPI_VIDEO_DEVICE",
Value: "\\_SB.PCI0.GFX0",
})
I meant all three values.
Done
Patch Set #11, Line 240: SATA Controller 1
SATA Controller (AHCI)
Done
Patch Set #11, Line 242: SATA Controller 2
SATA Controller (Legacy)
Done
Patch Set #11, Line 250: PCI-LPC bridge
Drop this part, it will result in "LPC bridge PCI-LPC bridge"
Done
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
Drop these
Done
Patch Set #11, Line 435: // the lid is open by default.
/* The lid is open by default. […]
Done
File util/autoport/lynxpoint.go:
Patch Set #12, Line 128: switch g {
The indentation is rather odd here
Now I've used gofmt to reformat the code.
To view, visit change 30890. To unsubscribe, or for help writing mail filters, visit settings.