Felix Held submitted this change.

View Change

Approvals: Felix Singer: Looks good to me, approved build bot (Jenkins): Verified Felix Held: Looks good to me, approved
nb/intel/gm45/raminit: Use read32p()

Built roda/rk9 with BUILD_TIMELESS=1 and the resulting coreboot.rom
remains identical.

Change-Id: Ib1e7144eebf8148c4eb5cc0e7bc03ae3d7281092
Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/77971
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/northbridge/intel/gm45/raminit.c
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/northbridge/intel/gm45/raminit.c b/src/northbridge/intel/gm45/raminit.c
index a998d77..b7e0139 100644
--- a/src/northbridge/intel/gm45/raminit.c
+++ b/src/northbridge/intel/gm45/raminit.c
@@ -1965,7 +1965,7 @@
jedec_command(rankaddr, DCC_CMD_ABP, 0);
jedec_command(rankaddr, DCC_CMD_CBR, 0);
udelay(1);
- read32((void *)(rankaddr));
+ read32p(rankaddr);

jedec_command(rankaddr, DCC_SET_MREG, WR | CAS | BTinterleaved | BL8);
jedec_command(rankaddr, DCC_SET_EREGx(1), OCDdefault | ODT_150OHMS);

To view, visit change 77971. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib1e7144eebf8148c4eb5cc0e7bc03ae3d7281092
Gerrit-Change-Number: 77971
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes Haouas <ehaouas@noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged