Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27808 )
Change subject: mb/google/poppy/variants/rammus: add rammus devicetree.cb ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/#/c/27808/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/rammus/devicetree.cb:
PS1: More of a TODO for myself: It would be good to check if poppy and variants can be converted to use override devicetree.
https://review.coreboot.org/#/c/27808/1/src/mainboard/google/poppy/variants/... PS1, Line 47: 2 0?
https://review.coreboot.org/#/c/27808/1/src/mainboard/google/poppy/variants/... PS1, Line 82: #| IccMax | 4A | 28A | 24A | 24A | This is already being set here: https://review.coreboot.org/c/coreboot/+/27610, so setting of IccMax here is not required.
https://review.coreboot.org/#/c/27808/1/src/mainboard/google/poppy/variants/... PS1, Line 328: on off