Attention is currently required from: Arthur Heymans, Benjamin Doron, Lean Sheng Tan, Leon Groß, Nico Huber, Paul Menzel.
11 comments:
Commit Message:
`Possible unwrapped commit description (prefer a maximum 72 chars per line)`
Please fix.
`Possible unwrapped commit description (prefer a maximum 72 chars per line)`
Please fix.
Patchset:
I think having this board for training makes a lot of sense.
File Documentation/mainboard/emulation/simics-qsp.md:
Remove this comma please.
because...
, then
remove 'of'
Patch Set #17, Line 36: Make sure to adjust the version numbers and file paths in the commands to your local installation.
Please add a final newline.
File src/cpu/qemu-x86/Kconfig:
Patch Set #17, Line 17: BOARD_EMULATION_SIMICS_QSP_X86_BOARDX58ICH10
I know that you're not responsible for the initial issue, but we should never have cpu/chipset options that depend on which board is selected.
The correct way to do this is to create a new Kconfig option that is selected by the board, like SMM_UNSUPPORTED or HIDE_SMM_OPTIONS.
I can fix that in a follow on to this patch.
File src/mainboard/emulation/simics-qsp/mainboard.c:
// static const struct pci_driver nb_driver __pci_driver = {
// .ops = &nb_operations,
// .vendor = 0x8086,
// .device = 0x29c0,
// };
Please don't add commented-out code.
File src/southbridge/intel/i82801jx/Kconfig:
Patch Set #17, Line 6: if !BOARD_EMULATION_SIMICS_QSP_X86_BOARDX58ICH10
Again, we don't want board configs gating common code. The way to do this is to create a config option "NO_COMMON_MADT_LAPIC" and select that in the board, then gate this option on that.
To view, visit change 77905. To unsubscribe, or for help writing mail filters, visit settings.