16 comments:
DPM is used for power manager, which is mediatek proprietary, it's binary release. […]
Done
Patch Set #5, Line 10: TEST=Boots correctly on Asurada
Dpm is tested pass with firmware 13457.0. […]
Done
File src/soc/mediatek/mt8192/dpm.c:
dm_file_bytes = cbfs_boot_load_file(dm_file_name, dpm_dm_bin,
sizeof(dpm_dm_bin), CBFS_TYPE_RAW);
if (dm_file_bytes == 0) {
printk(BIOS_ERR, "binary %s not found\n", dm_file_name);
return -1;
}
pm_file_bytes = cbfs_boot_load_file(pm_file_name, dpm_pm_bin,
sizeof(dpm_pm_bin), CBFS_TYPE_RAW);
if (pm_file_bytes == 0) {
printk(BIOS_ERR, "binary %s not found\n", pm_file_name);
return -2;
}
I will squash CB:46932 into this patch in next patchset.
Done
File src/soc/mediatek/mt8192/dpm.c:
Just one tab, or […]
Done
Patch Set #32, Line 29: binary %s not found
Failed to load %s
Done
Patch Set #32, Line 34: sizeof(dpm_pm_bin), CBFS_TYPE_RAW);
Same.
Please review new API proposed in CB:47895 CB:47896 CB:47897.
Patch Set #32, Line 36: binary %s not found
Failed to load %s
ditto
Use "%zu" (or "%#zx" if you prefer hex), and no need to cast it to "int".
ditto
Patch Set #32, Line 40: (int)
Please align with "BIOS_INFO".
ditto
Patch Set #32, Line 43: write32(&mtk_dpm->sw_rstn, read32(&mtk_dpm->sw_rstn) | 0x10000000);
Use clrsetbits32.
Done
Patch Set #32, Line 43: 0x10000000
Please define a macro for this.
Done
Patch Set #32, Line 54: write32(&mtk_dpm->sw_rstn, read32(&mtk_dpm->sw_rstn) | 0x1);
Use clrsetbits32.
Done
Please define a macro for this.
Done
File src/soc/mediatek/mt8192/include/soc/addressmap.h:
AUXADC_BASE = IO_PHYS + 0x01001000,
DPM_PM_SRAM_BASE = IO_PHYS + 0x00900000,
DPM_DM_SRAM_BASE = IO_PHYS + 0x00920000,
DPM_CFG_BASE = IO_PHYS + 0x00940000,
Please sort these by values.
Done
File src/soc/mediatek/mt8192/include/soc/dpm.h:
Patch Set #32, Line 10: 0x8000
Use KiB?
unused, removed.
Patch Set #32, Line 44: #define mtk_dpm ((struct dpm_regs *)DPM_CFG_BASE)
Use global variable to be consistent with others.
Done
To view, visit change 46393. To unsubscribe, or for help writing mail filters, visit settings.