Patch Set 10:

(1 comment)

Why is it needed? As far as I understand FSP 2.1, that introduced
MP_SERVICES_PPI, also introduced shared stack when selecting
FSP_USES_CB_STACK.
Simply select FSP_USES_CB_STACK when using MP_SERVICES_PPI should
fix the issue.

The reason is that, on FSP2.0 platform also we might need to enable MP PPI feature but same stack sharing concept might not applied on FSP 2.0 enabled platform, hence we are looking for some solution to bypass stack dependencies.

Reading the commit message of https://review.coreboot.org/c/coreboot/+/30310 it sounds like MP PPI feature is only available on FSP2.1. Is it available on all FSP2.0 platforms as well?

View Change

To view, visit change 26346. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55023a3e0cf42f0496d45bc6af8ead447f402350
Gerrit-Change-Number: 26346
Gerrit-PatchSet: 10
Gerrit-Owner: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich@gmail.com>
Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Comment-Date: Sat, 04 May 2019 06:50:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment