Patch Set 18: Code-Review+1

can you split the changes to the common amd code into another patch? the rest is probably ready for submitting (only thing that keeps me from +2ing the patch is the mix of mainboard and common code in this patch) and if there are some small changes needed they can be done in a follow-up patch

Good catch... it should not be here, this is a later development (completely new and apart of this one). Added by mistake. Will remove.

View Change

To view, visit change 33993. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5a366ddeb4cfebd177a8744f6edb87aecd4787dd
Gerrit-Change-Number: 33993
Gerrit-PatchSet: 18
Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Kerry Brown <kerry.brown@silverbackltd.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel@silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Tue, 03 Sep 2019 20:08:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment