5 comments:
File src/mainboard/asus/a88xm-e/bootblock.c:
Patch Set #47, Line 34: pnp_devfn_t uart = PNP_DEV(0x2e, IT8728F_SP1);
Make these const?
Done.
File src/mainboard/asus/a88xm-e/buildOpts.c:
Patch Set #47, Line 63: //#define BLDOPT_REMOVE_UDIMMS_SUPPORT TRUE
Can this be aligned with tabs please?
Done.
Patch Set #47, Line 197: // #define BLDCFG_SMBUS0_BASE_ADDRESS 0xB00
Are these commented-out entries needed?
Yes - at least for the reference
Patch Set #47, Line 238: { AMD_AP_MTRR_FIX16k_A0000, 0x0000000000000000 },
nit: Add a space before the hex numbers to align them
Done.
File src/mainboard/asus/a88xm-e/irq_tables.c:
Patch Set #47, Line 21: static void write_pirq_info(struct irq_info *pirq_info, u8 bus, u8 devfn,
This function makes things much less clear than directly writing the fields
In any case this whole IRQ routing will be rewritten later...
To view, visit change 30987. To unsubscribe, or for help writing mail filters, visit settings.