Attention is currently required from: Martin L Roth.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76911?usp=email )
Change subject: lib/smbios: Add 32 bit entry point if below 4G
......................................................................
Patch Set 1:
(1 comment)
File src/lib/smbios.c:
https://review.coreboot.org/c/coreboot/+/76911/comment/b8dee122_98367ed9 :
PS1, Line 1215: if (current < UINT32_MAX) {
I think for now they're always going to be below 4GiB, so I don't think this check is even needed […]
I will mark it as resolved since this is something for another patch.
Although looking at this code again after some time I feel like I would still like to keep the comment even if I would use your suggested function.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76911?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4cb426bb0c45282ed03ff4c65d15004b7f985dab
Gerrit-Change-Number: 76911
Gerrit-PatchSet: 1
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Comment-Date: Sun, 03 Dec 2023 20:01:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-MessageType: comment