Attention is currently required from: Angel Pons.
2 comments:
Patchset:
Hi! Thanks for the review again and sorry for the confusion with the "pin/pad" (I fixed this to use "pin" only).
File src/ec/kontron/kempld/kempld_internal.h:
#define KEMPLD_GPIO_MASK(x) (1 << ((x) % 8))
#define KEMPLD_GPIO_DIR(pad_num) (0x40 + (pad_num) / 8)
#define KEMPLD_GPIO_LVL(pad_num) (0x42 + (pad_num) / 8)
nit: Use the same name for the macro parameters, e.g. […]
Done
To view, visit change 47595. To unsubscribe, or for help writing mail filters, visit settings.