View Change
1 comment:
Patchset:
Patch Set #11:
Hi, […]
Hello Nick,
Back when this patch was pushed, it was decided that there wont be support for any version of brya hardware before P2. Since this was confirmed I had pushed this patch. If I recall correctly along with this, there were I2C changes related to TPM which had corresponding support in depthcharge which made hardware before P2 not bootable in payload phase. If you are adding support for old brya hardware back, you might want to redo the depthcharge part based on some board/sku id.
Thanks!
To view, visit change 56621. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a3bf13ec844fb46e11ce58382057fcc7187c135
Gerrit-Change-Number: 56621
Gerrit-PatchSet: 11
Gerrit-Owner: Varshit Pandya <pandyavarshit@gmail.com>
Gerrit-Reviewer: EricR Lai <ericr_lai@compal.corp-partner.google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg@chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot@gmail.com>
Gerrit-CC: Maulik Vaghela <maulikvaghela@google.com>
Gerrit-CC: Nick Vaccaro <nvaccaro@google.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Comment-Date: Sat, 01 Oct 2022 09:11:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nick Vaccaro <nvaccaro@google.com>
Gerrit-MessageType: comment