262 comments:
File src/security/intel/stm/SmmStm.c:
Patch Set #4, Line 178: ResourceHi = (uint64_t) Resource->Io.Base +
code indent should use tabs where possible
Patch Set #4, Line 178: ResourceHi = (uint64_t) Resource->Io.Base +
please, no space before tabs
Patch Set #4, Line 178: ResourceHi = (uint64_t) Resource->Io.Base +
please, no spaces at the start of a line
Patch Set #4, Line 181: RecordHi = (uint64_t) Record->Io.Base +
code indent should use tabs where possible
Patch Set #4, Line 181: RecordHi = (uint64_t) Record->Io.Base +
please, no space before tabs
Patch Set #4, Line 181: RecordHi = (uint64_t) Record->Io.Base +
please, no spaces at the start of a line
Patch Set #4, Line 185: if ((Resource->PciCfg.OriginatingBusNumber !=
suspect code indent for conditional statements (16, 32)
Patch Set #4, Line 188: Record->PciCfg.LastNodeIndex))
trailing whitespace
trailing whitespace
Patch Set #4, Line 191: if (memcmp (Resource->PciCfg.PciDevicePath,
suspect code indent for conditional statements (16, 32)
Patch Set #4, Line 191: if (memcmp (Resource->PciCfg.PciDevicePath,
space prohibited between function name and open parenthesis '('
Patch Set #4, Line 201: RecordHi = (uint64_t) Record->PciCfg.Base +
trailing whitespace
Patch Set #4, Line 218: // Special case - merge MSR masks in place.
code indent should use tabs where possible
Patch Set #4, Line 218: // Special case - merge MSR masks in place.
please, no space before tabs
Patch Set #4, Line 218: // Special case - merge MSR masks in place.
please, no spaces at the start of a line
code indent should use tabs where possible
please, no space before tabs
please, no spaces at the start of a line
Patch Set #4, Line 222: Record->Msr.ReadMask |= Resource->Msr.ReadMask;
trailing whitespace
Patch Set #4, Line 223: Record->Msr.WriteMask |= Resource->Msr.WriteMask;
trailing whitespace
Patch Set #4, Line 232: return false;
code indent should use tabs where possible
Patch Set #4, Line 232: return false;
please, no space before tabs
Patch Set #4, Line 232: return false;
please, no spaces at the start of a line
trailing whitespace
Patch Set #4, Line 240: // Resources are overlapping.
code indent should use tabs where possible
Patch Set #4, Line 240: // Resources are overlapping.
please, no space before tabs
Patch Set #4, Line 240: // Resources are overlapping.
please, no spaces at the start of a line
Patch Set #4, Line 241: // Resource and record are merged.
code indent should use tabs where possible
Patch Set #4, Line 241: // Resource and record are merged.
please, no space before tabs
Patch Set #4, Line 241: // Resource and record are merged.
please, no spaces at the start of a line
code indent should use tabs where possible
please, no space before tabs
please, no spaces at the start of a line
Patch Set #4, Line 246: switch (Resource->Header.RscType) {
code indent should use tabs where possible
Patch Set #4, Line 246: switch (Resource->Header.RscType) {
please, no space before tabs
Patch Set #4, Line 246: switch (Resource->Header.RscType) {
please, no spaces at the start of a line
Patch Set #4, Line 251: break;
code indent should use tabs where possible
Patch Set #4, Line 251: break;
please, no space before tabs
Patch Set #4, Line 251: break;
please, no spaces at the start of a line
Patch Set #4, Line 254: Record->Io.Base = (uint64_t) ResourceLo;
code indent should use tabs where possible
Patch Set #4, Line 254: Record->Io.Base = (uint64_t) ResourceLo;
please, no space before tabs
Patch Set #4, Line 254: Record->Io.Base = (uint64_t) ResourceLo;
please, no spaces at the start of a line
Patch Set #4, Line 255: Record->Io.Length = (uint64_t) (ResourceHi - ResourceLo);
code indent should use tabs where possible
Patch Set #4, Line 255: Record->Io.Length = (uint64_t) (ResourceHi - ResourceLo);
please, no space before tabs
Patch Set #4, Line 255: Record->Io.Length = (uint64_t) (ResourceHi - ResourceLo);
please, no spaces at the start of a line
Patch Set #4, Line 256: break;
code indent should use tabs where possible
Patch Set #4, Line 256: break;
please, no space before tabs
Patch Set #4, Line 256: break;
please, no spaces at the start of a line
Patch Set #4, Line 260: break;
trailing whitespace
Patch Set #4, Line 262: return false;
code indent should use tabs where possible
Patch Set #4, Line 262: return false;
please, no space before tabs
Patch Set #4, Line 262: return false;
please, no spaces at the start of a line
Patch Set #4, Line 288: Record = (STM_RSC *)((void *)Record + Record->Header.Length);
line over 80 characters
Patch Set #4, Line 289: continue;
code indent should use tabs where possible
Patch Set #4, Line 289: continue;
please, no space before tabs
Patch Set #4, Line 289: continue;
please, no spaces at the start of a line
Patch Set #4, Line 294: if (HandleSingleResource (Resource, Record)) {
space prohibited between function name and open parenthesis '('
Patch Set #4, Line 294: if (HandleSingleResource (Resource, Record)) {
braces {} are not necessary for single statement blocks
Patch Set #4, Line 295: return ;
space prohibited before semicolon
trailing whitespace
code indent should use tabs where possible
please, no space before tabs
please, no spaces at the start of a line
Patch Set #4, Line 303: memcpy (
space prohibited between function name and open parenthesis '('
Patch Set #4, Line 308: memcpy (
space prohibited between function name and open parenthesis '('
Patch Set #4, Line 309: mStmResourcesPtr + mStmResourceSizeUsed - sizeof(mRscEndNode) + Resource->Header.Length,
line over 80 characters
Patch Set #4, Line 314: mStmResourceSizeAvailable = mStmResourceTotalSize - mStmResourceSizeUsed;
line over 80 characters
Patch Set #4, Line 316: return ;
space prohibited before semicolon
void function return statements are not generally useful
Patch Set #4, Line 334: if (NumEntries == 0) {
braces {} are not necessary for any arm of this statement
trailing whitespace
please, no spaces at the start of a line
Patch Set #4, Line 343: if (Resource->Header.RscType == END_OF_RESOURCES)
code indent should use tabs where possible
Patch Set #4, Line 343: if (Resource->Header.RscType == END_OF_RESOURCES)
please, no space before tabs
Patch Set #4, Line 343: if (Resource->Header.RscType == END_OF_RESOURCES)
please, no spaces at the start of a line
Patch Set #4, Line 344: return ;
space prohibited before semicolon
Patch Set #4, Line 345: AddSingleResource (Resource);
space prohibited between function name and open parenthesis '('
Patch Set #4, Line 346: Resource = (STM_RSC *)((void *)Resource + Resource->Header.Length);
line over 80 characters
Patch Set #4, Line 348: return ;
space prohibited before semicolon
void function return statements are not generally useful
Patch Set #4, Line 357: If 0, list must be terminated by END_OF_RESOURCES.
code indent should use tabs where possible
Patch Set #4, Line 372: // END_OF_RESOURCES.
trailing whitespace
trailing whitespace
Patch Set #4, Line 374: if (NumEntries == 0) {
braces {} are not necessary for any arm of this statement
Patch Set #4, Line 376: } else {
suspect code indent for conditional statements (8, 8)
trailing whitespace
trailing whitespace
please, no spaces at the start of a line
Patch Set #4, Line 386: printk(BIOS_DEBUG, "ValidateResource (%llu) - RscType(%x)\n", Index, Resource->Header.RscType);
line over 80 characters
Patch Set #4, Line 386: printk(BIOS_DEBUG, "ValidateResource (%llu) - RscType(%x)\n", Index, Resource->Header.RscType);
Prefer using '"%s...", __func__' to using 'ValidateResource', this function's name, in a string
Patch Set #4, Line 388: // Validate resource.
trailing whitespace
trailing whitespace
Patch Set #4, Line 392: if (Resource->Header.Length != sizeof (STM_RSC_END))
space prohibited between function name and open parenthesis '('
code indent should use tabs where possible
Patch Set #4, Line 395: // If we are passed actual number of resources to add,
code indent should use tabs where possible
Patch Set #4, Line 396: // END_OF_RESOURCES structure between them is considered an
code indent should use tabs where possible
Patch Set #4, Line 397: // error. If NumEntries == 0 END_OF_RESOURCES is a termination.
trailing whitespace
Patch Set #4, Line 397: // error. If NumEntries == 0 END_OF_RESOURCES is a termination.
code indent should use tabs where possible
code indent should use tabs where possible
Patch Set #4, Line 401: } else {
else is not generally useful after a break or return
code indent should use tabs where possible
Patch Set #4, Line 403: // If NumEntries == 0 and list reached end - return success.
code indent should use tabs where possible
trailing whitespace
code indent should use tabs where possible
Patch Set #4, Line 411: if (Resource->Header.Length != sizeof (STM_RSC_MEM_DESC))
line over 80 characters
Patch Set #4, Line 411: if (Resource->Header.Length != sizeof (STM_RSC_MEM_DESC))
space prohibited between function name and open parenthesis '('
trailing whitespace
code indent should use tabs where possible
please, no spaces at the start of a line
Patch Set #4, Line 419: case TRAPPED_IO_RANGE:
trailing whitespace
Patch Set #4, Line 420: if (Resource->Header.Length != sizeof (STM_RSC_IO_DESC))
space prohibited between function name and open parenthesis '('
Patch Set #4, Line 428: printk(BIOS_DEBUG, "ValidateResource - PCI (0x%02x, 0x%08x, 0x%02x, 0x%02x)\n", Resource->PciCfg.OriginatingBusNumber, Resource->PciCfg.LastNodeIndex, Resource->PciCfg.PciDevicePath[0].PciDevice, Resource->PciCfg.PciDevicePath[0].PciFunction);
line over 80 characters
Patch Set #4, Line 428: printk(BIOS_DEBUG, "ValidateResource - PCI (0x%02x, 0x%08x, 0x%02x, 0x%02x)\n", Resource->PciCfg.OriginatingBusNumber, Resource->PciCfg.LastNodeIndex, Resource->PciCfg.PciDevicePath[0].PciDevice, Resource->PciCfg.PciDevicePath[0].PciFunction);
Prefer using '"%s...", __func__' to using 'ValidateResource', this function's name, in a string
Patch Set #4, Line 429: if (Resource->Header.Length != sizeof (STM_RSC_PCI_CFG_DESC) + (sizeof(STM_PCI_DEVICE_PATH_NODE) * Resource->PciCfg.LastNodeIndex))
line over 80 characters
Patch Set #4, Line 429: if (Resource->Header.Length != sizeof (STM_RSC_PCI_CFG_DESC) + (sizeof(STM_PCI_DEVICE_PATH_NODE) * Resource->PciCfg.LastNodeIndex))
space prohibited between function name and open parenthesis '('
Patch Set #4, Line 431: for (SubIndex = 0; SubIndex <= Resource->PciCfg.LastNodeIndex; SubIndex++) {
line over 80 characters
Patch Set #4, Line 432: if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice > 0x1F) || (Resource->PciCfg.PciDevicePath[SubIndex].PciFunction > 7)) {
line over 80 characters
Patch Set #4, Line 432: if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice > 0x1F) || (Resource->PciCfg.PciDevicePath[SubIndex].PciFunction > 7)) {
braces {} are not necessary for single statement blocks
Patch Set #4, Line 436: if ((Resource->PciCfg.Base + Resource->PciCfg.Length) > 0x1000) {
line over 80 characters
Patch Set #4, Line 436: if ((Resource->PciCfg.Base + Resource->PciCfg.Length) > 0x1000) {
code indent should use tabs where possible
Patch Set #4, Line 436: if ((Resource->PciCfg.Base + Resource->PciCfg.Length) > 0x1000) {
please, no space before tabs
Patch Set #4, Line 436: if ((Resource->PciCfg.Base + Resource->PciCfg.Length) > 0x1000) {
please, no spaces at the start of a line
Patch Set #4, Line 436: if ((Resource->PciCfg.Base + Resource->PciCfg.Length) > 0x1000) {
braces {} are not necessary for single statement blocks
Patch Set #4, Line 437: return false;
code indent should use tabs where possible
Patch Set #4, Line 437: return false;
please, no space before tabs
Patch Set #4, Line 437: return false;
please, no spaces at the start of a line
code indent should use tabs where possible
please, no space before tabs
please, no spaces at the start of a line
Patch Set #4, Line 439: break;
code indent should use tabs where possible
Patch Set #4, Line 439: break;
please, no space before tabs
Patch Set #4, Line 439: break;
please, no spaces at the start of a line
Patch Set #4, Line 442: if (Resource->Header.Length != sizeof (STM_RSC_MSR_DESC)) {
line over 80 characters
Patch Set #4, Line 442: if (Resource->Header.Length != sizeof (STM_RSC_MSR_DESC)) {
space prohibited between function name and open parenthesis '('
Patch Set #4, Line 442: if (Resource->Header.Length != sizeof (STM_RSC_MSR_DESC)) {
braces {} are not necessary for single statement blocks
trailing whitespace
code indent should use tabs where possible
please, no spaces at the start of a line
Patch Set #4, Line 448: printk(BIOS_DEBUG, "ValidateResource - Unknown RscType(%x)\n", Resource->Header.RscType);
line over 80 characters
Patch Set #4, Line 448: printk(BIOS_DEBUG, "ValidateResource - Unknown RscType(%x)\n", Resource->Header.RscType);
Prefer using '"%s...", __func__' to using 'ValidateResource', this function's name, in a string
Patch Set #4, Line 451: Resource = (STM_RSC *)((void *)Resource + Resource->Header.Length);
line over 80 characters
Patch Set #4, Line 453: return true;
code indent should use tabs where possible
Patch Set #4, Line 453: return true;
please, no space before tabs
Patch Set #4, Line 453: return true;
please, no spaces at the start of a line
Patch Set #4, Line 479: // END_OF_RESOURCES.
trailing whitespace
trailing whitespace
Patch Set #4, Line 481: if (NumEntries == 0) {
braces {} are not necessary for any arm of this statement
Patch Set #4, Line 482: Count = 0xFFFFFFFF;
code indent should use tabs where possible
Patch Set #4, Line 482: Count = 0xFFFFFFFF;
please, no space before tabs
Patch Set #4, Line 482: Count = 0xFFFFFFFF;
please, no spaces at the start of a line
trailing whitespace
Patch Set #4, Line 493: if (Resource->Header.RscType == END_OF_RESOURCES) {
braces {} are not necessary for single statement blocks
Patch Set #4, Line 511: @retval EFI_OUT_OF_RESOURCES If nested procedure returned it and we cannot allocate more areas.
line over 80 characters
Patch Set #4, Line 521: printk(BIOS_DEBUG, "AddPiResource - Enter\n");
Prefer using '"%s...", __func__' to using 'AddPiResource', this function's name, in a string
Patch Set #4, Line 523: if (!ValidateResource (ResourceList, NumEntries)) {
space prohibited between function name and open parenthesis '('
Patch Set #4, Line 523: if (!ValidateResource (ResourceList, NumEntries)) {
braces {} are not necessary for single statement blocks
Patch Set #4, Line 527: ResourceSize = GetResourceSize (ResourceList, NumEntries);
space prohibited between function name and open parenthesis '('
Patch Set #4, Line 528: printk (BIOS_DEBUG, "ResourceSize - 0x%08llx\n", ResourceSize);
space prohibited between function name and open parenthesis '('
Patch Set #4, Line 529: if (ResourceSize == 0) {
braces {} are not necessary for single statement blocks
Patch Set #4, Line 535: // Copy EndResource for intialization
'intialization' may be misspelled - perhaps 'initialization'?
Patch Set #4, Line 544: memcpy (mStmResourcesPtr, &mRscEndNode, sizeof(mRscEndNode));
space prohibited between function name and open parenthesis '('
Patch Set #4, Line 546: mStmResourceSizeAvailable = mStmResourceTotalSize - sizeof(mRscEndNode);
line over 80 characters
Patch Set #4, Line 552: } else if (mStmResourceSizeAvailable < ResourceSize) {
suspect code indent for conditional statements (8, 8)
Patch Set #4, Line 584: // TBD
code indent should use tabs where possible
Patch Set #4, Line 584: // TBD
please, no space before tabs
Patch Set #4, Line 584: // TBD
please, no spaces at the start of a line
Patch Set #4, Line 585: //ASSERT (false);
code indent should use tabs where possible
Patch Set #4, Line 585: //ASSERT (false);
please, no space before tabs
Patch Set #4, Line 585: //ASSERT (false);
please, no spaces at the start of a line
Patch Set #4, Line 591: memcpy (mStmResourcesPtr, &mRscEndNode, sizeof(mRscEndNode));
space prohibited between function name and open parenthesis '('
Patch Set #4, Line 593: mStmResourceSizeAvailable = mStmResourceTotalSize - sizeof(mRscEndNode);
code indent should use tabs where possible
Patch Set #4, Line 593: mStmResourceSizeAvailable = mStmResourceTotalSize - sizeof(mRscEndNode);
please, no space before tabs
Patch Set #4, Line 593: mStmResourceSizeAvailable = mStmResourceTotalSize - sizeof(mRscEndNode);
please, no spaces at the start of a line
Patch Set #4, Line 604: or the size of resource list to be filled if size of too small.
line over 80 characters
Patch Set #4, Line 607: @retval BUFFER_TOO_SMALL If resource list buffer is too small to hold the whole resources.
line over 80 characters
Patch Set #4, Line 612: if (*ResourceSize < mStmResourceSizeUsed) {
suspect code indent for conditional statements (8, 8)
Patch Set #4, Line 617: memcpy (ResourceList, mStmResourcesPtr, mStmResourceSizeUsed);
space prohibited between function name and open parenthesis '('
Patch Set #4, Line 618: *ResourceSize = (uint32_t)mStmResourceSizeUsed;
code indent should use tabs where possible
Patch Set #4, Line 618: *ResourceSize = (uint32_t)mStmResourceSizeUsed;
please, no space before tabs
Patch Set #4, Line 618: *ResourceSize = (uint32_t)mStmResourceSizeUsed;
please, no spaces at the start of a line
Patch Set #4, Line 619: return 0;//EFI_SUCCESS;
code indent should use tabs where possible
Patch Set #4, Line 619: return 0;//EFI_SUCCESS;
please, no space before tabs
Patch Set #4, Line 619: return 0;//EFI_SUCCESS;
please, no spaces at the start of a line
Patch Set #4, Line 633: MsrData64.msr = rdmsr (IA32_VMX_BASIC_MSR_INDEX);
trailing whitespace
Patch Set #4, Line 633: MsrData64.msr = rdmsr (IA32_VMX_BASIC_MSR_INDEX);
space prohibited between function name and open parenthesis '('
Patch Set #4, Line 637: printk(BIOS_DEBUG, "GetVmcsSize: Size %d StmSupport %d\n", ThisVmcsSize, StmSupport);
line over 80 characters
Patch Set #4, Line 637: printk(BIOS_DEBUG, "GetVmcsSize: Size %d StmSupport %d\n", ThisVmcsSize, StmSupport);
code indent should use tabs where possible
Patch Set #4, Line 637: printk(BIOS_DEBUG, "GetVmcsSize: Size %d StmSupport %d\n", ThisVmcsSize, StmSupport);
please, no spaces at the start of a line
Patch Set #4, Line 637: printk(BIOS_DEBUG, "GetVmcsSize: Size %d StmSupport %d\n", ThisVmcsSize, StmSupport);
Prefer using '"%s...", __func__' to using 'GetVmcsSize', this function's name, in a string
Patch Set #4, Line 642: ThisVmcsSize = STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (ThisVmcsSize));
space prohibited between function name and open parenthesis '('
Patch Set #4, Line 642: ThisVmcsSize = STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (ThisVmcsSize));
space prohibited between function name and open parenthesis '('
Patch Set #4, Line 657: UINTN Index;
code indent should use tabs where possible
Patch Set #4, Line 657: UINTN Index;
please, no space before tabs
Patch Set #4, Line 657: UINTN Index;
please, no spaces at the start of a line
Patch Set #4, Line 661: Pte = (uint32_t*)(uint32_t)PageTableBase;
"(foo*)" should be "(foo *)"
Patch Set #4, Line 664: for (Index = 0; Index < SIZE_4KB / sizeof (*Pte); Index++) {
space prohibited between function name and open parenthesis '('
Patch Set #4, Line 670: return ;
space prohibited before semicolon
void function return statements are not generally useful
Patch Set #4, Line 689: Pml4 = (uint64_t*)(uint32_t) PageTableBase;
"(foo*)" should be "(foo *)"
Patch Set #4, Line 693: Pde = (uint64_t*)(uint32_t)PageTableBase;
"(foo*)" should be "(foo *)"
Patch Set #4, Line 702: for (SubIndex = 0; SubIndex < SIZE_4KB / sizeof(*Pte); SubIndex++) {
line over 80 characters
Patch Set #4, Line 703: *Pte = (((Index << 9) + SubIndex) << 21) | IA32_PG_PS | IA32_PG_RW | IA32_PG_P;
line over 80 characters
Patch Set #4, Line 708: return ;
space prohibited before semicolon
void function return statements are not generally useful
Patch Set #4, Line 725: STM_HEADER *StmHeader;
please, no space before tabs
Patch Set #4, Line 732: MinMsegSize = (STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (StmHeader->SwStmHdr.StaticImageSize)) +
line over 80 characters
Patch Set #4, Line 732: MinMsegSize = (STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (StmHeader->SwStmHdr.StaticImageSize)) +
space prohibited between function name and open parenthesis '('
Patch Set #4, Line 732: MinMsegSize = (STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (StmHeader->SwStmHdr.StaticImageSize)) +
space prohibited between function name and open parenthesis '('
Patch Set #4, Line 734: (StmHeader->SwStmHdr.PerProcDynamicMemorySize + GetVmcsSize () * 2) * mp_state.cpu_count);
line over 80 characters
Patch Set #4, Line 734: (StmHeader->SwStmHdr.PerProcDynamicMemorySize + GetVmcsSize () * 2) * mp_state.cpu_count);
space prohibited between function name and open parenthesis '('
Patch Set #4, Line 735: if (MinMsegSize < StmImageSize) {
braces {} are not necessary for single statement blocks
Patch Set #4, Line 739: if (StmHeader->HwStmHdr.Cr3Offset >= StmHeader->SwStmHdr.StaticImageSize) {
line over 80 characters
Patch Set #4, Line 743: if (MinMsegSize < StmHeader->HwStmHdr.Cr3Offset + STM_PAGES_TO_SIZE(6)) {
line over 80 characters
Patch Set #4, Line 743: if (MinMsegSize < StmHeader->HwStmHdr.Cr3Offset + STM_PAGES_TO_SIZE(6)) {
braces {} are not necessary for single statement blocks
Patch Set #4, Line 744: MinMsegSize = StmHeader->HwStmHdr.Cr3Offset + STM_PAGES_TO_SIZE(6);
line over 80 characters
Patch Set #4, Line 751: if (MinMsegSize > CONFIG_MSEG_SIZE) {
braces {} are not necessary for single statement blocks
Patch Set #4, Line 781: //memcpy ((void *)(uint32_t)MsegBase, (void *)(uint32_t)StmImage, StmImageSize);
line over 80 characters
Patch Set #4, Line 785: if (sizeof(UINTN) == sizeof(uint64_t)) {
braces {} are not necessary for any arm of this statement
Patch Set #4, Line 786: StmGen4GPageTableX64 ((UINTN)MsegBase + StmHeader->HwStmHdr.Cr3Offset);
line over 80 characters
Patch Set #4, Line 786: StmGen4GPageTableX64 ((UINTN)MsegBase + StmHeader->HwStmHdr.Cr3Offset);
space prohibited between function name and open parenthesis '('
Patch Set #4, Line 788: StmGen4GPageTableIa32 ((UINTN)MsegBase + StmHeader->HwStmHdr.Cr3Offset);
line over 80 characters
Patch Set #4, Line 788: StmGen4GPageTableIa32 ((UINTN)MsegBase + StmHeader->HwStmHdr.Cr3Offset);
space prohibited between function name and open parenthesis '('
Patch Set #4, Line 804: @retval EFI_BUFFER_TOO_SMALL MSEG is smaller than minimal requirement of STM image
line over 80 characters
Patch Set #4, Line 814: if (SmmMonCtlMsr.bits.MsegAddress == 0) {
braces {} are not necessary for single statement blocks
Patch Set #4, Line 822: if (!StmCheckStmImage (StmImage, StmImageSize)) {
space prohibited between function name and open parenthesis '('
Patch Set #4, Line 822: if (!StmCheckStmImage (StmImage, StmImageSize)) {
braces {} are not necessary for single statement blocks
Patch Set #4, Line 827: // Record STM_HASH to PCR 0, just in case it is NOT TXT launch, we still need provide the evidence.
line over 80 characters
Patch Set #4, Line 833: (void *)StmImage, // HashData
code indent should use tabs where possible
Patch Set #4, Line 833: (void *)StmImage, // HashData
please, no space before tabs
Patch Set #4, Line 833: (void *)StmImage, // HashData
please, no spaces at the start of a line
Patch Set #4, Line 837: StmLoadStmImage (StmImage, StmImageSize);
space prohibited between function name and open parenthesis '('
trailing whitespace
code indent should use tabs where possible
please, no spaces at the start of a line
File src/security/intel/stm/StmApi.h:
Patch Set #4, Line 155: uint64_t AcpiRsdp;
code indent should use tabs where possible
Patch Set #4, Line 155: uint64_t AcpiRsdp;
please, no space before tabs
Patch Set #4, Line 155: uint64_t AcpiRsdp;
please, no spaces at the start of a line
Patch Set #4, Line 156: uint8_t PhysicalAddressBits;
code indent should use tabs where possible
Patch Set #4, Line 156: uint8_t PhysicalAddressBits;
please, no space before tabs
Patch Set #4, Line 156: uint8_t PhysicalAddressBits;
please, no spaces at the start of a line
Patch Set #4, Line 247: uint32_t Cr4; // fe40h : NO
code indent should use tabs where possible
Patch Set #4, Line 247: uint32_t Cr4; // fe40h : NO
please, no space before tabs
Patch Set #4, Line 247: uint32_t Cr4; // fe40h : NO
please, no spaces at the start of a line
Patch Set #4, Line 253: uint32_t IdtLimit; // fe98h : NO
trailing whitespace
Patch Set #4, Line 258: uint32_t LdtInfo; // fea4h : NO
trailing whitespace
Patch Set #4, Line 266: uint32_t SMMRevId; // fefch : NO
code indent should use tabs where possible
Patch Set #4, Line 266: uint32_t SMMRevId; // fefch : NO
please, no space before tabs
Patch Set #4, Line 266: uint32_t SMMRevId; // fefch : NO
please, no spaces at the start of a line
Patch Set #4, Line 505: //#define DOMAIN_INTEGRITY_PROT_OUT (DOMAIN_INTEGRITY | DOMAIN_DISALLOWED_IO_IN)
line over 80 characters
Patch Set #4, Line 507: //#define DOMAIN_FULLY_PROT_IN (DOMAIN_CONFIDENTIALITY | DOMAIN_INTEGRITY | DOMAIN_DISALLOWED_IO_OUT)
line over 80 characters
Patch Set #4, Line 508: //#define DOMAIN_FULLY_PROT_OUT (DOMAIN_CONFIDENTIALITY | DOMAIN_INTEGRITY | DOMAIN_DISALLOWED_IO_IN)
line over 80 characters
Patch Set #4, Line 509: #define DOMAIN_FULLY_PROT (DOMAIN_CONFIDENTIALITY | DOMAIN_INTEGRITY | DOMAIN_DISALLOWED_IO_IN | DOMAIN_DISALLOWED_IO_OUT)
line over 80 characters
Patch Set #4, Line 751: #pragma pack (pop)
space prohibited between function name and open parenthesis '('
File src/security/intel/stm/StmPlatformResource.c:
Patch Set #4, Line 143: // Index Read Write
trailing whitespace
Patch Set #4, Line 167: //mTsegSize = (uint32_t)(~((uint32_t)rdmsr(SMRR_PHYSMASK_MSR) & 0xFFFFF000) + 1);
line over 80 characters
trailing whitespace
please, no spaces at the start of a line
trailing whitespace
please, no spaces at the start of a line
File src/security/intel/stm/StmPlatformSmm.c:
Patch Set #4, Line 61: StmGen4GPageTableX64 ((uint32_t)MsegBase +
space prohibited between function name and open parenthesis '('
Patch Set #4, Line 79: struct descriptor{
missing space after struct definition
Patch Set #4, Line 87: void ReadGdtr( struct descriptor *gdtr)
space prohibited after that open parenthesis '('
To view, visit change 33234. To unsubscribe, or for help writing mail filters, visit settings.