Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79367?usp=email )
Change subject: ec/lenovo/h8/acpi/thermal: Make NameSeg FPWR all upper case ......................................................................
ec/lenovo/h8/acpi/thermal: Make NameSeg FPWR all upper case
Building the Lenovo T60/T60p, iasl 20230628 shows the remark below:
dsdt.asl 2099: PowerResource (FPwR, 0, 0) Remark 2182 - ^ At least one lower case letter found in NameSeg, ASL is case insensitive - converting to upper case (FPWR)
dsdt.asl 2118: Name (_PR0, Package () { FPwR }) Remark 2182 - ^ At least one lower case letter found in NameSeg, ASL is case insensitive - converting to upper case (FPWR)
Address it by making it all upper case.
Change-Id: Ia7924b015e76c43818d2d82da35ce0013d721c26 Fixes: 3ab13a8691cb ("ec/lenovo/h8/acpi/thermal: Add support for passive cooling") Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/79367 Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Felix Singer service+coreboot-gerrit@felixsinger.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/ec/lenovo/h8/acpi/thermal.asl 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Nico Huber: Looks good to me, but someone else must approve
diff --git a/src/ec/lenovo/h8/acpi/thermal.asl b/src/ec/lenovo/h8/acpi/thermal.asl index 4f3b76e..fa5a282 100644 --- a/src/ec/lenovo/h8/acpi/thermal.asl +++ b/src/ec/lenovo/h8/acpi/thermal.asl @@ -97,7 +97,7 @@
Name (_AL0, Package () { FAN })
- PowerResource (FPwR, 0, 0) + PowerResource (FPWR, 0, 0) { /* * WINDOWS BUG: Don't read from EmbeddedControl @@ -127,7 +127,7 @@ Device (FAN) { Name (_HID, EISAID ("PNP0C0B")) - Name (_PR0, Package () { FPwR }) + Name (_PR0, Package () { FPWR }) } }