4 comments:
File src/soc/amd/picasso/acpi.c:
fadt->smi_cmd = 0; /* disable system management mode */
fadt->acpi_enable = 0; /* unused if SMI_CMD = 0 */
fadt->acpi_disable = 0; /* unused if SMI_CMD = 0 */
should still remain in the else section.
fadt->s4bios_req = 0; /* Not supported */
fadt->pstate_cnt = 0; /* Not supported */
Same comment as for stoney, 3 lines setting values to 0 should be outside the if/else
File src/soc/amd/stoneyridge/acpi.c:
fadt->smi_cmd = 0; /* disable system management mode */
fadt->acpi_enable = 0; /* unused if SMI_CMD = 0 */
These 3 line:
fadt->smi_cmd = 0; /* disable system management mode */
fadt->acpi_enable = 0; /* unused if SMI_CMD = 0 */
fadt->acpi_disable = 0; /* unused if SMI_CMD = 0 *
Were not moved anywhere, so should still be within an else branch.
Patch Set #3, Line 100: fadt->s4bios_req = 0; /* Not supported */
These 3 lines (setting variables to 0) were common on both sides of the if/else, so now it should be outside the if.
To view, visit change 36811. To unsubscribe, or for help writing mail filters, visit settings.