Some minor comments/questions.

Otherwise, it LGTM but I don't have the expertise to give a +2.

Patch set 35:Code-Review +1

View Change

10 comments:

• Commit Message:

  • Patch Set #35, Line 19: ports

    port's

  • Patch Set #35, Line 33:

    
    Not going to implement:
    

    Does that mean never, or not in this commit, or something in between?

• File src/mainboard/razer/blade_stealth_kbl/acpi/battery.asl:

  • Patch Set #35, Line 62: St

    The indentation looks broken here (8 spaces here vs. two tabs in surrounding lines)

  • Patch Set #35, Line 70: S

    dito

• File src/mainboard/razer/blade_stealth_kbl/acpi/ec.asl:

  • Patch Set #35, Line 27: Name

    dito, for most of the file.

  • Patch Set #35, Line 75: // Store Lids -> \Lids should be working...

    Can you explain this comment in more detail, please? What works, what doesn't?

• File src/mainboard/razer/blade_stealth_kbl/board_info.txt:

  • Patch Set #35, Line 1: razer

    This is inconsistent with the string in Kconfig (RAZER vs. razer); not sure if intended.

• File src/mainboard/razer/blade_stealth_kbl/devicetree.cb:

  • Patch Set #35, Line 274: subsystemid 0x1a58 0x6752

    There is a way to set the subsystem ID once and for all PCI devices, which makes sense *if* the vendor firmware also sets it for all devices (I don't know if it does).

    The trick is to write `subsystemid 0x1a58 0x6752 inherit` into the `device domain 0` block. Example:
    https://review.coreboot.org/cgit/coreboot.git/tree/src/mainboard/msi/ms9652_fam10/devicetree.cb#n26

• File src/mainboard/razer/blade_stealth_kbl/hda_verb.c:

  • Patch Set #35, Line 25: //

    The indentation is weird here (tab+space)

• File src/mainboard/razer/blade_stealth_kbl/spd/Makefile.inc:

  • Patch Set #35, Line 21: b0001

    I think this should rather be index 0 (0b0000) and index 1 (0b0001)

To view, visit change 34475. To unsubscribe, or for help writing mail filters, visit settings.