I have looked at my Latitude 6430u firmware binary, disassembled a little and the code you have written looks the same for my laptop. If you address the suggestions in the comments, I can give +2

View Change

To view, visit change 44975. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iee68ea52dcf0242315868a46b5e4768303e30dce
Gerrit-Change-Number: 44975
Gerrit-PatchSet: 2
Gerrit-Owner: Iru Cai (vimacs) <mytbk920423@gmail.com>
Gerrit-Reviewer: Iru Cai <mytbk920423@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-CC: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-CC: Pablo Stebler <pablo@stebler.xyz>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sun, 11 Oct 2020 16:50:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment