Attention is currently required from: Brandon Breitenstein. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47684 )
Change subject: soc/tigerlake: Update early TCSS code to not call back and forth between mainboard and soc ......................................................................
Patch Set 2:
(5 comments)
Patchset:
PS2: Comments from patchset#1 still need to be addressed.
File src/soc/intel/tigerlake/early_tcss.c:
https://review.coreboot.org/c/coreboot/+/47684/comment/97c941c2_64d6a1cc PS2, Line 286: system_requires_early_display As commented earlier, you can use `display_init_required()` here.
https://review.coreboot.org/c/coreboot/+/47684/comment/cc39b9d5_7b60a259 PS2, Line 296: __weak I don't think we need the weak implementation. If a mainboard selects EARLY_TCSS then it must provide this function definition.
File src/soc/intel/tigerlake/include/soc/early_tcss.h:
https://review.coreboot.org/c/coreboot/+/47684/comment/351e5ed0_a31ac184 PS2, Line 129: //void update_tcss_mux(int port, struct tcss_mux mux_data); Drop this instead of commenting out.
https://review.coreboot.org/c/coreboot/+/47684/comment/39471734_50a7ee1f PS2, Line 141: mainboard_early_tcss_enable I think this should be named `mainboard_fill_tcss_mux_info()` since the enabling is performed by SoC code.