Felix Held submitted this change.
soc/amd/common/block/include/lpc: add comment about RANGE_UNIT values
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I22f3485ec81f76af7e0e96b7c1271d5ccf52e701
Reviewed-on: https://review.coreboot.org/c/coreboot/+/60771
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
---
M src/soc/amd/common/block/include/amdblocks/lpc.h
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/soc/amd/common/block/include/amdblocks/lpc.h b/src/soc/amd/common/block/include/amdblocks/lpc.h
index 173cbd1..558b608 100644
--- a/src/soc/amd/common/block/include/amdblocks/lpc.h
+++ b/src/soc/amd/common/block/include/amdblocks/lpc.h
@@ -74,7 +74,7 @@
#define ROM_BASE_MASK 0xfffff000 /* bits 31-12 */
#define ROM_RANGE_WP BIT(10)
#define ROM_RANGE_RP BIT(9)
-#define RANGE_UNIT BIT(8)
+#define RANGE_UNIT BIT(8) /* 0: 4kiB, 1: 64kiB */
#define RANGE_ADDR_MASK 0x000000ff /* Range defined by bits 7-0 */
#define ROM_PROTECT_RANGE_REG(n) (ROM_PROTECT_RANGE0 + (4 * n))
#define MAX_ROM_PROTECT_RANGES 4
To view, visit change 60771. To unsubscribe, or for help writing mail filters, visit settings.