15 comments:
File src/include/blob_provider.h:
why can't we just use struct blob_locator? What do we gain from typedef'ing aside from not writing ' […]
Done
Patch Set #3, Line 48: ID_DATA_NVRAM_VPD_RO_REGION = 17,
put DATA_CODE_SPLIT in here?
Done
Patch Set #3, Line 234: *******
What's the purpose of the fixed width return type? And what are the expected return value?
Done
same question as above
Done
cli means what?
Done
Why are we passing a full object instead of just a const pointer?
Done
this is a weird name -- all caps and also not just cbfs.
Done
Why are we specifying policy on location based on id? […]
Done
Is there a reason to explode out all parameters? Why not jus tpass struct blob_locator?
Done
What's this mean?
Done
this is true only for x86
Done
Patch Set #3, Line 88: *size = region_device_sz(&data);
So we do mmap_full then munmap to make the hook read things?
Done
What does rd stand for?
Done
Patch Set #3, Line 104: printk(BIOS_ERR, "Can't use auto mmap function on code blob.");
?
Done
File src/lib/coreboot_table.c:
Patch Set #3, Line 511: blob_read_map(BLOB_DATA_NVRAM_CMOS_LAYOUT, NULL);
this should really be turned into a read.
Done
To view, visit change 24942. To unsubscribe, or for help writing mail filters, visit settings.