Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/24997 )
Change subject: mb/google/poppy/variants/nami: Add WACOM EMR support ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/24997/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nami/devicetree.cb:
https://review.coreboot.org/#/c/24997/1/src/mainboard/google/poppy/variants/... PS1, Line 277: GPP_D2 This is not the pen power enable gpio. It is the detect pin.
https://review.coreboot.org/#/c/24997/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nami/gpio.c:
https://review.coreboot.org/#/c/24997/1/src/mainboard/google/poppy/variants/... PS1, Line 170: 1 Why do you need to take it out of reset here? It should be done by the power resource that you have added in ACPI.