Attention is currently required from: Nico Huber, Arthur Heymans, Kyösti Mälkki.
4 comments:
Patchset:
It looks functionally different on everything but fam14
I don't exactly understand what is different? Could you elaborate?
File src/northbridge/amd/agesa/family15tn/northbridge.c:
Patch Set #2, Line 48: temp = pci_read_config32(dev, 0x144 + (nodeid <<3)) & 0xff; //[47:40] at [7:0]
This is gone?
Yes it is gone, we would need to support at least ~256GB of DRAM memory to have any other value than 0 in this register. Although CONFIG_CPU_ADDR_BITS is 48 (for virtual address space) this register describes only real DRAM in the system. I made a simplification based on reasonable conclusion that such an old system's mobile memory controller cannot support more than 16GB or 32GB of DRAM.
File src/northbridge/amd/agesa/family16kb/northbridge.c:
Patch Set #2, Line 48: temp = pci_read_config32(dev, 0x144 + (nodeid <<3)) & 0xff; //[47:40] at [7:0]
This is gone?
As above.
File src/northbridge/amd/pi/00730F01/northbridge.c:
Patch Set #2, Line 53: temp = pci_read_config32(dev, 0x144 + (nodeid <<3)) & 0xff; //[47:40] at [7:0]
this is gone?
As above
To view, visit change 52922. To unsubscribe, or for help writing mail filters, visit settings.