Felix Held submitted this change.

View Change


Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
soc/amd/morgana: Add TODOs for common code to Kconfig

This allows us to see which of the common code blocks have been verified
and which have not.

Signed-off-by: Martin Roth <martin.roth@amd.corp-partner.google.com>
Change-Id: Icb9eba5838013de75c408c28a4a7d3afacdf0674
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68555
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
---
M src/soc/amd/morgana/Kconfig
1 file changed, 56 insertions(+), 40 deletions(-)

diff --git a/src/soc/amd/morgana/Kconfig b/src/soc/amd/morgana/Kconfig
index f150d51..a1261c9 100644
--- a/src/soc/amd/morgana/Kconfig
+++ b/src/soc/amd/morgana/Kconfig
@@ -39,46 +39,46 @@
select RESET_VECTOR_IN_RAM
select RTC
select SOC_AMD_COMMON
- select SOC_AMD_COMMON_BLOCK_ACP_GEN2
- select SOC_AMD_COMMON_BLOCK_ACPI
- select SOC_AMD_COMMON_BLOCK_ACPIMMIO
- select SOC_AMD_COMMON_BLOCK_ACPI_ALIB
- select SOC_AMD_COMMON_BLOCK_ACPI_CPPC
- select SOC_AMD_COMMON_BLOCK_ACPI_GPIO
- select SOC_AMD_COMMON_BLOCK_ACPI_IVRS
- select SOC_AMD_COMMON_BLOCK_AOAC
- select SOC_AMD_COMMON_BLOCK_APOB
- select SOC_AMD_COMMON_BLOCK_APOB_HASH
- select SOC_AMD_COMMON_BLOCK_BANKED_GPIOS
- select SOC_AMD_COMMON_BLOCK_DATA_FABRIC
- select SOC_AMD_COMMON_BLOCK_EMMC
- select SOC_AMD_COMMON_BLOCK_ESPI_EXTENDED_DECODE_RANGES
- select SOC_AMD_COMMON_BLOCK_GRAPHICS
- select SOC_AMD_COMMON_BLOCK_HAS_ESPI
- select SOC_AMD_COMMON_BLOCK_HAS_ESPI_ALERT_ENABLE
- select SOC_AMD_COMMON_BLOCK_I2C
- select SOC_AMD_COMMON_BLOCK_I23C_PAD_CTRL
- select SOC_AMD_COMMON_BLOCK_IOMMU
- select SOC_AMD_COMMON_BLOCK_LPC
- select SOC_AMD_COMMON_BLOCK_MCAX
- select SOC_AMD_COMMON_BLOCK_NONCAR
- select SOC_AMD_COMMON_BLOCK_PCI
- select SOC_AMD_COMMON_BLOCK_PCI_MMCONF
- select SOC_AMD_COMMON_BLOCK_PCIE_GPP_DRIVER
- select SOC_AMD_COMMON_BLOCK_PM
- select SOC_AMD_COMMON_BLOCK_PM_CHIPSET_STATE_SAVE
- select SOC_AMD_COMMON_BLOCK_PSP_GEN2
- select SOC_AMD_COMMON_BLOCK_SMBUS
- select SOC_AMD_COMMON_BLOCK_SMI
- select SOC_AMD_COMMON_BLOCK_SMM
- select SOC_AMD_COMMON_BLOCK_SMU
- select SOC_AMD_COMMON_BLOCK_SPI
- select SOC_AMD_COMMON_BLOCK_TSC_FAM17H_19H
- select SOC_AMD_COMMON_BLOCK_UART
- select SOC_AMD_COMMON_BLOCK_UCODE
- select SOC_AMD_COMMON_FSP_CCX_CPPC_HOB
- select SOC_AMD_COMMON_FSP_DMI_TABLES
- select SOC_AMD_COMMON_FSP_PCI
+ select SOC_AMD_COMMON_BLOCK_ACP_GEN2 # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_ACPI # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_ACPIMMIO # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_ACPI_ALIB # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_ACPI_CPPC # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_ACPI_GPIO # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_ACPI_IVRS # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_AOAC # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_APOB # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_APOB_HASH # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_BANKED_GPIOS # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_DATA_FABRIC # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_EMMC # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_ESPI_EXTENDED_DECODE_RANGES # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_GRAPHICS # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_HAS_ESPI # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_HAS_ESPI_ALERT_ENABLE # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_I2C # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_I23C_PAD_CTRL # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_IOMMU # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_LPC # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_MCAX # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_NONCAR # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_PCI # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_PCI_MMCONF # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_PCIE_GPP_DRIVER # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_PM # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_PM_CHIPSET_STATE_SAVE # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_PSP_GEN2 # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_SMBUS # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_SMI # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_SMM # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_SMU # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_SPI # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_TSC_FAM17H_19H # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_UART # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_BLOCK_UCODE # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_FSP_CCX_CPPC_HOB # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_FSP_DMI_TABLES # TODO: Check if this is still correct
+ select SOC_AMD_COMMON_FSP_PCI # TODO: Check if this is still correct
select SSE2
select UDK_2017_BINDING
select USE_FSP_NOTIFY_PHASE_POST_PCI_ENUM

To view, visit change 68555. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb9eba5838013de75c408c28a4a7d3afacdf0674
Gerrit-Change-Number: 68555
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless@gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Martin Roth <martin.roth@amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged