3 comments:
File src/mainboard/pcengines/apu2/gpio_ftns.c:
Patch Set #1, Line 13: if (gpio >= 0x300)
I agree, but boundary checking should be enforced by SOC code.
Ack
Patch Set #1, Line 16: return gpio0_read32(gpio & 0x3ff);
Yes, sorry. As before in my other comments it was about maintaining proper API and abstractions. […]
Ack
File src/mainboard/pcengines/apu2/romstage.c:
Patch Set #7, Line 36: gpio_output(gpio, setting & GPIO_OUTPUT_VALUE);
To avoid glitches ?
gpio_output(gpio, gpio_input(gpio));
gpio_output(gpio, setting & GPIO_OUTPUT_VALUE);
Below, iomux_write() below might have to move too.
Or maybe remove this configure_gpio() altogether and call program_gpios().
To view, visit change 42521. To unsubscribe, or for help writing mail filters, visit settings.