28 Feb
2019
28 Feb
'19
1:50 p.m.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31617 )
Change subject: superio/ite/it8613e: add support for ITE IT8613E ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31617/4/src/superio/ite/it8613e/superio.c File src/superio/ite/it8613e/superio.c:
https://review.coreboot.org/#/c/31617/4/src/superio/ite/it8613e/superio.c@74 PS4, Line 74: 0x0fff is this mask correct? I don't have the datasheet, but this seems a bit unusual to me; guessing from other ITE SIO datasheets, I'd expect 0x0ff8 here (if this is the simple I/O BAR)
--
To view, visit https://review.coreboot.org/c/coreboot/+/31617
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I73c083b7019163c1203a5aabbef7d9d8f5ccb16a
Gerrit-Change-Number: 31617
Gerrit-PatchSet: 4
Gerrit-Owner: Krystian Hebel krystian.hebel@3mdeb.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Krystian Hebel krystian.hebel@3mdeb.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 28 Feb 2019 12:50:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment