7 Feb
2023
7 Feb
'23
11:46 a.m.
Attention is currently required from: Elyes Haouas.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72757 )
Change subject: acpi/acpigen.h: Fix ACPI OP codes ......................................................................
Patch Set 4:
(1 comment)
File src/include/acpi/acpigen.h:
https://review.coreboot.org/c/coreboot/+/72757/comment/47b82898_ea6bf129 PS4, Line 49: EVENT_OP = 0x02, i'd split the patch into two parts. one to fix the wrong definition for EVENT_OP and one to drop the definitions that are now deprecated (at least that's what i'd guess). the first part could already be submitted, while the second part partially depends on a previous patch in this patch train
--
To view, visit https://review.coreboot.org/c/coreboot/+/72757
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51e7f8dc6c0bfef0816ab4da6d96cb0fac873ee8
Gerrit-Change-Number: 72757
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-Attention: Elyes Haouas ehaouas@noos.fr
Gerrit-Comment-Date: Tue, 07 Feb 2023 11:46:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment