5 comments:
File src/soc/amd/stoneyridge/Kconfig:
## Merlinfalcon only supports FP4.
Meh, I could do without this comment. It's already in the help text, and you could embellish that if you feel it's necessary.
Patch Set #3, Line 32: config SOC_AMD_PSP_SELECTABLE_SMU_FW
Move this item to below CPU_SPECIFIC_OPTIONS somewhere. I'd probably put it just above SOC_AMD_SMU_FANLESS.
Some PSP implementations allow storing SMU firmware into cbfs and
calling the PSP to load the blobs at the proper time.
The soc/<codename> should select this if its PSP supports the feature
and each mainboard can choose to select an appropriate fanless or
fanned set of blobs. Ask your AMD representative whether your APU
is considered fanless.
You're free to override the default help text with anything you want. If MF or ST is selected, then someone checks the help for this option, I think this might be confusing. You could say that some ST implementations support "storing SMU firmware...". And that MF doesn't support it.
File src/soc/amd/stoneyridge/Makefile.inc:
Patch Set #3, Line 204: endif
This starts to get confusing. Instead of the additions in lines 166, 168, 171, 174, 196, 198, 201, 203 see if simply inserting at the following at 205 works for you.
ifeq ("$(wildcard $(SMUFWM_FN_FILE))","")
SMUFWM_FN_FILE=
SMUFIRMWARE2_FN_FILE=
endif
Patch Set #3, Line 225: ifeq ($(CONFIG_SOC_AMD_PSP_SELECTABLE_SMU_FW),y)
You probably won't need this. I believe the add_opt_prefix should assign emptiness to the variables if there's no input file.
To view, visit change 33621. To unsubscribe, or for help writing mail filters, visit settings.