Attention is currently required from: Felix Held, Paul Menzel.
Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84380?usp=email )
Change subject: soc/amd/glinda/.../iomap.h: Update for glinda ......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84380/comment/89bc03ce_92403950?usp... : PS4, Line 10: DMA4 apparently doesn't exist anymore so remove it.
no; it's just not visible in the ppr version you have access to :(
I see. Thanks for checking. I updated the patch to only include the removal of the TODO now.
File src/soc/amd/glinda/include/soc/iomap.h:
https://review.coreboot.org/c/coreboot/+/84380/comment/80ef75d0_169cf3f1?usp... : PS4, Line 35: #define APU_DMAC4_BASE 0xfedd0000
this is still there; just not visible in the non-internal ppr. […]
Done