[coreboot-gerrit] [M] Change in coreboot[master]: cpu/x86/cache: CLFLUSH programs to memory before running

[Arthur Heymans (Code Review)]

Attention is currently required from: Raul Rangel, Nico Huber, Michał Żygowski, Subrata Banik, Reka Norman, Michał Kopeć, Angel Pons, Felix Held.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37196 )

Change subject: cpu/x86/cache: CLFLUSH programs to memory before running
......................................................................


Patch Set 23:

(1 comment)

Patchset:

PS23:
> > > > will this config also helps Xeon platforms?
> > >
> > > It should help all Intel platform that supports CLFLUSH IMO.
> >
> > Well on SPR xeon-sp against recommendations TempRamExit was overloaded with functionality to write things to DRAM to speed things up and therefore made mandatory in the bootflow. CLFLUSHING would have been a way better solution, as invalidating cache in a different environment (FSP) is just though to get right even from a security perspective...
>
> ah, i missed that SPR is still using FSP-T

CAR setup is indeed quite complicated on Xeon-SP and requires FSP-T for now (coherency needs to be set up across CPUs). However CAR teardown is the same as (e)NEM. On CPX and SKX coreboot CAR teardown is used over FSP-M TempRamExit. On SPR-SP that's not possible anymore due to the modified bootflow.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/37196
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ff2a57aee620908b71829457ea0f5a0c410ec5b
Gerrit-Change-Number: 37196
Gerrit-PatchSet: 23
Gerrit-Owner: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Felix Held <[e-mail]>
Gerrit-Reviewer: Kapil Porwal <[e-mail]>
Gerrit-Reviewer: Lean Sheng Tan <[e-mail]>
Gerrit-Reviewer: Marshall Dawson <[e-mail]>
Gerrit-Reviewer: Martin L Roth <[e-mail]>
Gerrit-Reviewer: Michał Kopeć <[e-mail]>
Gerrit-Reviewer: Michał Żygowski <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: Raul Rangel <[e-mail]>
Gerrit-Reviewer: Sean Rhodes <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Aaron Durbin <[e-mail]>
Gerrit-CC: Daocheng Bu <[e-mail]>
Gerrit-CC: David Hendricks <[e-mail]>
Gerrit-CC: Furquan Shaikh <[e-mail]>
Gerrit-CC: Jonathan Zhang <[e-mail]>
Gerrit-CC: Marc Jones <[e-mail]>
Gerrit-CC: Nico Huber <[e-mail]>
Gerrit-CC: Nill Ge <[e-mail]>
Gerrit-CC: Reka Norman <[e-mail]>
Gerrit-Attention: Raul Rangel <[e-mail]>
Gerrit-Attention: Nico Huber <[e-mail]>
Gerrit-Attention: Michał Żygowski <[e-mail]>
Gerrit-Attention: Subrata Banik <[e-mail]>
Gerrit-Attention: Reka Norman <[e-mail]>
Gerrit-Attention: Michał Kopeć <[e-mail]>
Gerrit-Attention: Angel Pons <[e-mail]>
Gerrit-Attention: Felix Held <[e-mail]>
Gerrit-Comment-Date: Fri, 10 Mar 2023 08:13:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <[e-mail]>
Comment-In-Reply-To: Arthur Heymans <[e-mail]>
Comment-In-Reply-To: Lean Sheng Tan <[e-mail]>
Gerrit-MessageType: comment