Attention is currently required from: Raul Rangel, Patrick Rudolph, Mariusz Szafrański, Jonathan Zhang, Paul Menzel, Angel Pons, Jason Glenesk, Anjaneya "Reddy" Chagam, Martin Roth, Marshall Dawson, Johnny Lin, Tim Wawrzynczak, Christian Walter, Suresh Bellampalli, Michal Motyl, Felix Held, Tim Chu.
View Change
6 comments:
File src/include/device/pci_ids.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139657):
Patch Set #9, Line 2116: #define PCI_VID_AKS 0x416c
'AKS' may be misspelled - perhaps 'ASK'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139657):
Patch Set #9, Line 2117: #define PCI_DID_AKS_ALADDINCARD 0x0100
'AKS' may be misspelled - perhaps 'ASK'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139657):
Patch Set #9, Line 2118: #define PCI_DID_AKS_CPC 0x0200
'AKS' may be misspelled - perhaps 'ASK'?
File src/soc/intel/skylake/vr_config.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139657):
Patch Set #9, Line 215: (igd_id == PCI_DID_INTEL_KBL_GT3E_SULTM_2)) {
code indent should use tabs where possible
File src/southbridge/amd/agesa/hudson/hudson.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139657):
Patch Set #9, Line 66: else if (sd_device_id == PCI_DID_AMD_YANGTZE_SD) {
else should follow close brace '}'
File src/southbridge/amd/pi/hudson/hudson.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139657):
Patch Set #9, Line 41: else if (sd_device_id == PCI_DID_AMD_YANGTZE_SD) {
else should follow close brace '}'
To view, visit change 39331. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If9027700f53b6d0d3964c26a41a1f9b8f62be178
Gerrit-Change-Number: 39331
Gerrit-PatchSet: 9
Gerrit-Owner: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam@intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com>
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Guckian <d.guckian20@gmail.com>
Gerrit-Reviewer: David Guckian <david.guckian@intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin@wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski@intel.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Reviewer: Michal Motyl <michalx.motyl@intel.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli@intel.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu@quantatw.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio@intel.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Martin Roth <martinroth@google.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Raul Rangel <rrangel@chromium.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski@intel.com>
Gerrit-Attention: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam@intel.com>
Gerrit-Attention: Martin Roth <martinroth@google.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin@wiwynn.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Attention: Christian Walter <christian.walter@9elements.com>
Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli@intel.com>
Gerrit-Attention: Michal Motyl <michalx.motyl@intel.com>
Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Attention: Tim Chu <Tim.Chu@quantatw.com>
Gerrit-Comment-Date: Tue, 01 Feb 2022 13:36:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment