Attention is currently required from: Nico Huber, Werner Zeh, Andrey Petrov.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64493 )
Change subject: soc/intel/apollolake: Measure bootblock from IFWI
......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/apollolake/include/soc/iomap.h:
https://review.coreboot.org/c/coreboot/+/64493/comment/fcb8f408_4cecfdd3
PS5, Line 34: #define SHARED_SRAM_BASE 0xffff8000
: #define SHARED_SRAM_SIZE (32 * KiB)
Does it make sense to extend the region device for this case? We do not access the contents in this use case. Or shall I move the defines over to bootblock_measure.c to stay consistent?
I think it makes sense. If someone wants to measure the microcode updates or print out the FIT table or elements of it... I'm not sure if that will happen but there is no harm in using the full size here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64493
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifb3f798de638a85029ebfe0d1b65770029297db3
Gerrit-Change-Number: 64493
Gerrit-PatchSet: 5
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: siemens-bot
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Mon, 23 May 2022 06:37:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment