[coreboot-gerrit] Change in coreboot[master]: soc/intel/common: Add CPU Crashlog PCI driver

[build bot (Jenkins) (Code Review)]

Attention is currently required from: Francois Toguo Fotso, Furquan Shaikh, Kane Chen, Patrick Rudolph, Karthik Ramasubramanian.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57685 )

Change subject: soc/intel/common: Add CPU Crashlog PCI driver
......................................................................


Patch Set 7:

(2 comments)

File src/soc/intel/common/block/crashlog/cpu_crashlog.c:

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139924):
https://review.coreboot.org/c/coreboot/+/57685/comment/85d9da82_6bac32c0 
PS7, Line 173: 		printk(BIOS_SPEW, "Collecting %u dwords from SRAM at %lx\n", buffer.size, bar + buffer.offset);
line over 96 characters


Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139924):
https://review.coreboot.org/c/coreboot/+/57685/comment/767737e8_74e24ad8 
PS7, Line 186: 	header_offset = crashlog_info.table.offset + offsetof(struct cpu_crashlog_table, header);
line over 96 characters



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/57685
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5cb61fa2570adcfe51680141ee12e0e83930bb19
Gerrit-Change-Number: 57685
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Wawrzynczak <[e-mail]>
Gerrit-Reviewer: Francois Toguo Fotso <[e-mail]>
Gerrit-Reviewer: Furquan Shaikh <[e-mail]>
Gerrit-Reviewer: Kane Chen <[e-mail]>
Gerrit-Reviewer: Karthik Ramasubramanian <[e-mail]>
Gerrit-Reviewer: Nick Vaccaro <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Attention: Francois Toguo Fotso <[e-mail]>
Gerrit-Attention: Furquan Shaikh <[e-mail]>
Gerrit-Attention: Kane Chen <[e-mail]>
Gerrit-Attention: Patrick Rudolph <[e-mail]>
Gerrit-Attention: Karthik Ramasubramanian <[e-mail]>
Gerrit-Comment-Date: Thu, 03 Feb 2022 21:49:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment