View Change

2 comments:

• File trace.c:

  • Patch Set #4, Line 264: always decode 4 bytes

    I am not sure I understand this comment.

    I removed the whole comment now, it made sense before I reworked the address selection code but not anymore.

  • Patch Set #4, Line 321: address += 16;

    Isn't this only for address_type != ADDR_NONE? Probably doesn't matter since it will not be used in […]

    Yes, the address is never printed, so in theory we could decide to only count up here when we are actually printing it.

    I had decided to simplify the code and "track" the index unconditionally
    to make the code a bit more straightforward.

    If you feel that's misguidedm I can put the conditional increase back in.

To view, visit change 48584. To unsubscribe, or for help writing mail filters, visit settings.