12 comments:
File src/soc/amd/stoneyridge/Makefile.inc:
Patch Set #28, Line 273: #cbfs-files-y += apu/amdfw
haven't tested, but i'd expect that this will cause issues for stoneyridge after this patch is merge […]
Yes. it has problem. If we want to avoid this, we have to squash all the next 3 patches into one. What do you think?
File util/amdfwtool/amdfwtool.h:
please add the spdx line: /* SPDX-License-Identifier: GPL-2. […]
Done. Added.
File util/amdfwtool/amdfwtool.c:
uint8_t g_have_whitelist, g_unlock_secure, g_use_secureos,
g_load_mp2_fw, g_s0i3;
this is unused and can be removed
Done. Removed.
Patch Set #28, Line 601: #if 0
see my comment below on this
Done
Patch Set #28, Line 1102: static void register_fw_fuses(int fd, amd_cb_config *cb_config)
i find this function name very misleading. […]
Done. Change to process_config_file
Patch Set #28, Line 1257: // int abl_image = 0;
please remove the commented out lines. same below.
Done
if (targetfd >= 0) {
ssize_t bytes;
bytes = write(targetfd, amd_romsig, ctx.current - romsig_offset);
if (bytes != ctx.current - romsig_offset)
retval = 1;
close(targetfd);
} else {
haven't tried, but splitting these lines out into another patch and moving it before the makefile ch […]
Done. Moved.
File util/amdfwtool/data_parse.c:
//extern uint8_t g_have_whitelist, g_unlock_secure, g_use_secureos,
// g_load_mp2_fw, g_s0i3;
please remove the commented out lines of code. same below.
Done
Patch Set #28, Line 84: subprog = 0;
writing to a function parameter, especially before it got read, seems to be a bug to me
Done. The subprog match check has been removed.
Patch Set #28, Line 405: #if 1
remove the #if 1 and corresponding #endif
Done
Patch Set #28, Line 474: unsigned int read_line(char **config, char **oneline)
this function seems to be sort-of a reimplementation of getline(). […]
Done. use fgets to get a line.
Patch Set #28, Line 498: void process_config(char *config, amd_cb_config *cb_config)
i'd pass the file handle instead of a char * with the file contents
Done. Changed.
To view, visit change 42859. To unsubscribe, or for help writing mail filters, visit settings.