Patch Set 3:

I am trying to compile after a `make distclean` and noticed if building with an existing .config it will error complaining that data.vbt cannot be found. This will be frustrating for both x230fhd and x230 users. Is there any way to migrate config settings to be:

CONFIG_INTEL_GMA_VBT_FILE="src/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/data.vbt"

That would require overriding the variant mechanism, AFAIK. And it's not like the VBT path is hidden or something, it can be easily changed by hand.

View Change

To view, visit change 28950. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Gerrit-Change-Number: 28950
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Tom Hiller <thrilleratplay@gmail.com>
Gerrit-Comment-Date: Sun, 07 Oct 2018 14:15:00 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No