Hung-Te Lin uploaded patch set #3 to this change.

View Change

cbfstool: Change FMD annotation to flags

The idea of "annotation" for firmware sections was pretty flexible, but
in future we will want multiple attributes applied to same section. For
example, in FMAP based output, the FMAP flags support "RO",
"compressed", and "static". As a result, it seems better to extend
annotation so it can take multiple identifiers (flags), for example

COREBOOT(CBFS RO STATIC)@##CBFS_BASE## ##CBFS_SIZE##

As a result, it seems better to list all supported flags in FMD parser
instead of allowing arbitrary string (and leaving all parsing complexity
into the callback function).

The annotation string is now directly parsed in fmd_parser, and stored
in an union flashmap_flags. Output modules can choose to ignore or
process the flags.

BUG=chromium:936768
TEST=make; boots an x86 image.

Change-Id: Ie2d99f570e6faff6ed3a4344d6af7526a4515fae
Signed-off-by: Hung-Te Lin <hungte@chromium.org>
---
M util/cbfstool/cbfs_sections.c
M util/cbfstool/fmd.h
M util/cbfstool/fmd_parser.c_shipped
M util/cbfstool/fmd_parser.h_shipped
M util/cbfstool/fmd_parser.y
M util/cbfstool/fmd_scanner.c_shipped
M util/cbfstool/fmd_scanner.h_shipped
M util/cbfstool/fmd_scanner.l
8 files changed, 352 insertions(+), 316 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/31706/3

To view, visit change 31706. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie2d99f570e6faff6ed3a4344d6af7526a4515fae
Gerrit-Change-Number: 31706
Gerrit-PatchSet: 3
Gerrit-Owner: Hung-Te Lin <hungte@chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: newpatchset