Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47684 )
Change subject: soc/tigerlake: Update early TCSS code to not call back and forth between mainboard and soc ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47684/1/src/soc/intel/tigerlake/ear... File src/soc/intel/tigerlake/early_tcss.c:
https://review.coreboot.org/c/coreboot/+/47684/1/src/soc/intel/tigerlake/ear... PS1, Line 281: extra line
https://review.coreboot.org/c/coreboot/+/47684/1/src/soc/intel/tigerlake/inc... File src/soc/intel/tigerlake/include/soc/early_tcss.h:
https://review.coreboot.org/c/coreboot/+/47684/1/src/soc/intel/tigerlake/inc... PS1, Line 141: mainboard_early_tcss_enable Could this return num_ports instead of passing it by reference?
Also I wonder if maybe a name like `mainboard_fill_tcss_mux_info` would be little more clear? WDYT?