Attention is currently required from: Bora Guvendik, Subrata Banik, Name of user not set #1004406, Michal Zygowski.

View Change

8 comments:

• File src/include/cpu/intel/cpu_ids.h:

  • Patch Set #3, Line 67: #define CPUID_RAPTORLAKE_S_S0 0xb0671

    CPUID_RAPTORLAKE_S_B0 it is B0 stepping according to the datasheet. And if so, I would also add: […]

    Ack

• File src/soc/intel/alderlake/bootblock/report_platform.c:

  • Patch Set #3, Line 37: { CPUID_RAPTORLAKE_S_S0, "Raptorlake-S S0 Platform" },

    { CPUID_RAPTORLAKE_S_B0, "Raptorlake-S B0 Platform" },

    Ack

  • Patch Set #3, Line 207:

    	{ PCI_DID_INTEL_RPL_S_GT1, "Raptorlake S GT1(32EU)" },
    	{ PCI_DID_INTEL_RPL_S_GT2, "Raptorlake S GT2(24EU)" },
    	{ PCI_DID_INTEL_RPL_S_GT3, "Raptorlake S GT3(16EU)" },
    

    Let's stick with previous convention and omit execution units.

    Ack

• File src/soc/intel/alderlake/fsp_params.c:

  • Patch Set #3, Line 544: return ICC_MAX_ADL_S;

    Isn't it 36A for RPL-S?

    Ack

• File src/soc/intel/alderlake/include/soc/cpu.h:

  • Patch Set #3, Line 28: RPL_S,

    Please add it as a last item in the enum

    Ack

• File src/soc/intel/alderlake/vr_config.c:

  • Patch Set #3, Line 174:

    { PCI_DID_INTEL_RPL_S_ID_1,  125, VR_CFG_ALL_DOMAINS_ICC(280, 30) },
    	{ PCI_DID_INTEL_RPL_S_ID_2,  125, VR_CFG_ALL_DOMAINS_ICC(280, 30) },
    

    RPL-S 8+16 and 8+8 have 307A ICCmax for IA domain.

    Ack

  • Patch Set #3, Line 176: { PCI_DID_INTEL_RPL_S_ID_3, 125, VR_CFG_ALL_DOMAINS_ICC(280, 30) },

    RPL-S 6+8 has 200A ICCmax for IA domain

    Ack

• File src/soc/intel/common/block/cpu/mp_init.c:

  • Patch Set #3, Line 84: { X86_VENDOR_INTEL, CPUID_RAPTORLAKE_S_S0 },

    { X86_VENDOR_INTEL, CPUID_RAPTORLAKE_S_B0 },

    Ack

To view, visit change 69798. To unsubscribe, or for help writing mail filters, visit settings.