Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39940 )
Change subject: mb/google/auron: Convert variants to use override devicetree ......................................................................
Patch Set 8: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/39940/6/src/mainboard/google/auron/... File src/mainboard/google/auron/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39940/6/src/mainboard/google/auron/... PS6, Line 15: # Enable Panel and configure power delays : register "gpu_panel_port_select" = "1" # eDP : register "gpu_panel_power_cycle_delay" = "5" # 400ms : register "gpu_panel_power_up_delay" = "400" # 40ms : register "gpu_panel_power_down_delay" = "150" # 15ms : register "gpu_panel_power_backlight_on_delay" = "2100" # 210ms : register "gpu_panel_power_backlight_off_delay" = "2100" # 210ms
figured it was easier just to keep them grouped for each board, in case they need adjustment at a la […]
Ack, I guess
https://review.coreboot.org/c/coreboot/+/39940/6/src/mainboard/google/auron/... File src/mainboard/google/auron/variants/buddy/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39940/6/src/mainboard/google/auron/... PS6, Line 34: device pci 1c.3 on end # PCIe Port #4 - WLAN (becomes RP2)
it's unused so no need to enable it
Ah, please mention it somewhere (e.g. commit message)
https://review.coreboot.org/c/coreboot/+/39940/6/src/mainboard/google/auron/... File src/mainboard/google/auron/variants/samus/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39940/6/src/mainboard/google/auron/... PS6, Line 29: Disable S0ix
for the past 5 years apparently
I'd still keep it, as it hints that something was wrong when using S0ix