Patch Set 4:

Please update the commit message and provide some
reasoning for this.

I already mentioned there the only benefit I knew at the moment of submission:
"This provides console output even if e.g. GRUB is the payload."


> What happens when it's not set?

Personally I have not noticed any "enabled vs disabled" differences while using SeaBIOS, but maybe that's because I never used a splashscreen. Thank you very much for information, I'm going to test it soon - and if it turns out that this config is required for showing a splashscreen, I will update the commit message with this new info.

View Change

To view, visit change 31325. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b4eacf61d905f1160531a988e192c3b626dca68
Gerrit-Change-Number: 31325
Gerrit-PatchSet: 4
Gerrit-Owner: mikeb mikeb <mikebdp2@gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: mikeb mikeb <mikebdp2@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Fri, 01 Mar 2019 06:53:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment