Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
mb/emulation/qemu-i440fx,q35: Fix comment style

The comment fits in 96 characters, so do it, also getting rid of the
unwanted multi-line comment style.

Add a dot/period to the end of the sentence.

Change-Id: I7b5c7ea5da00d649aa06361e0e0cf2431874a6ec
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42615
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
M src/mainboard/emulation/qemu-i440fx/mainboard.c
M src/mainboard/emulation/qemu-q35/mainboard.c
2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/mainboard/emulation/qemu-i440fx/mainboard.c b/src/mainboard/emulation/qemu-i440fx/mainboard.c
index 04bbb7d..929743a 100644
--- a/src/mainboard/emulation/qemu-i440fx/mainboard.c
+++ b/src/mainboard/emulation/qemu-i440fx/mainboard.c
@@ -20,9 +20,7 @@
for (i = 0; i < 6; i++)
pci_write_config8(dev, 0x5a + i, 0x33);

- /* This sneaked in here, because Qemu does not
- * emulate a SuperIO chip
- */
+ /* This sneaked in here, because Qemu does not emulate a SuperIO chip. */
pc_keyboard_init(NO_AUX_DEVICE);

/* setup IRQ routing */
diff --git a/src/mainboard/emulation/qemu-q35/mainboard.c b/src/mainboard/emulation/qemu-q35/mainboard.c
index c7e983a..d329e5a 100644
--- a/src/mainboard/emulation/qemu-q35/mainboard.c
+++ b/src/mainboard/emulation/qemu-q35/mainboard.c
@@ -26,9 +26,7 @@
pci_write_config8(dev, Q35_PAM0 + 5, 0x33);
pci_write_config8(dev, Q35_PAM0 + 6, 0x33);

- /* This sneaked in here, because Qemu does not
- * emulate a SuperIO chip
- */
+ /* This sneaked in here, because Qemu does not emulate a SuperIO chip. */
pc_keyboard_init(NO_AUX_DEVICE);

/* setup IRQ routing for pci slots */

To view, visit change 42615. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b5c7ea5da00d649aa06361e0e0cf2431874a6ec
Gerrit-Change-Number: 42615
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged