Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yu-Ping Wu.

View Change

5 comments:

• File payloads/libpayload/include/sysinfo.h:

  • Patch Set #2, Line 87: uintptr_t pcie_ctrl_base; /* PCIe controller base address */

    Can we use a struct here, because qualcomm will need to store 3 fields: config_base, config_size and […]

    Done

• File src/commonlib/include/commonlib/coreboot_tables.h:

  • Patch Set #3, Line 95: LB_TAG_PCIE = 0x00cd,

    Move this to line 89.

    Done

• File src/commonlib/include/commonlib/coreboot_tables.h:

  • Patch Set #2, Line 173: reg_base

    "config_base", or "conf_base", or "mmconf_base". […]

    Done, I also keep the ctrl_base since our driver need its controller base address.

  • Patch Set #2, Line 173: uintptr_t

    uint64_t

    Done

• File src/include/boot/coreboot_tables.h:

  • Patch Set #2, Line 24: pcie

    pci or pcie? Same for other names.

    I think pcie is sufficient, new device may not support pci device anymore.

To view, visit change 63251. To unsubscribe, or for help writing mail filters, visit settings.