6 comments:
Patch Set #39, Line 24: const char *const *pad_names; /* indexed by 'pad * func_count + func' */
Please don't mix comment styles. I guess C style (this here) is preferred, though.
Patch Set #39, Line 40: /* Description of GPIO 'bank' ex. {ncore, score. ssus} */
Mention that this is used for BayTrail? Also, maybe put it between
`new` and `old`?
Patch Set #39, Line 5: * Copyright (C) 2019 by 9elements Agency GmbH
For the added #includes?
File util/inteltool/gpio_baytrail.h:
Why is this a .h?
File util/inteltool/platform_i631x.c:
Maybe keep it alongside `gpio_ich`? Because of its similarity.
File util/inteltool/platform_lynxpoint.c:
This is for Lynx Point LP (low power) only. The file name should reflect that.
To view, visit change 31504. To unsubscribe, or for help writing mail filters, visit settings.