Patch Set 21:
(1 comment)
A lot less to review, if you just first renamed CACHE_RELOCATABLE_RAMSTAGE_OUTSIDE_CBMEM and adjusted the Makefile.inc files. The real contents of this commit appears to be in that src/Kconfig file only.
yes, you are right, i have just rename CACHE_RELOCATABLE_RAMSTAGE_OUTSIDE_CBMEM to USE_EXTERNAL_STAGE_CACHE isn't it ? and when user doesn't select this CACHE_RELOCATABLE_RAMSTAGE_OUTSIDE_CBMEM config naturally there will be an alternative option like USE_INTERNAL_STAGE_CACHE. i guess the change density might be same if i "just" rename the kconfig alone in one CL and in next CL, i have add concept of USE_INTERNAL_STAGE_CACHE.
1 comment:
File src/cpu/intel/smm/gen1/smmrelocate.c:
Patch Set #21, Line 124: if (CONFIG(USE_EXTERNAL_STAGE_CACHE)) {
Since this implies it's carved from TSEG/SMM, maybe the name EXTERNAL is not that good.
i guess USE_EXTERNAL_STAGE_CACHE kconfig has detailed help to know where it might like to store the stage cache, internal into cbmem or external to cbmem which could be TSEG region.
To view, visit change 33116. To unsubscribe, or for help writing mail filters, visit settings.