Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Angel Pons, Patrick Rudolph.
29 comments:
File Documentation/arch/x86/x86_64.md:
Patch Set #7, Line 4: In coreboot every stage (when enabled) is built for x86_64,
When enabled, every coreboot stage is built for x86_64,
Done
What does `it` refer to?
Done
Patch Set #7, Line 15: supports
must support
Done
This is the case for Pentium 4 or
compatible CPUs.
Not all Pentium 4's support x86_64, only Cedar Mill and some Prescott models do. […]
Done
must be
Done
Patch Set #7, Line 23: supports
must support
Done
Patch Set #7, Line 29: generates
must generate
Done
must have
Done
must be
Done
Patch Set #7, Line 36: those
nit: these
Done
Patch Set #7, Line 36: compability
Still not fixed: compa*ti*bility
Done
Patch Set #7, Line 40: phase
plural `phases`?
Done
If the above is changed to plural, this also needs to be changed to `run`
Done
nit: Capitalize `When` for consistency with the other bullet points
Done
Patch Set #7, Line 45: the compiler
Which one? `the compiler` sounds like there's only one compiler, which is not the case.
Done
Patch Set #7, Line 49: todays
today's
Done
Patch Set #7, Line 54: The high dword of pointers is always zero
Is this an actual requirement, or just a side effect? If it's a requirement, then please use imperat […]
Done
Patch Set #7, Line 70: those
nit: these
Done
have
Done
Patch Set #7, Line 71: those
nit: `these`, or just `the`
Done
Once
finished running those blobs it must switch back to long mode.
How about: […]
Done
Patch Set #7, Line 77: will be reported back
`is relayed back` or `is propagated back`
Done
drop one blank line?
Done
Patch Set #7, Line 91: pagetable
page tables
Done
the CPU
Done
Patch Set #7, Line 104: those
nit: these
Done
Patch Set #7, Line 109: Options
`Option` (`Option ROMs` is a compound name, the plural `s` is in `ROMs`)
Done
Patch Set #7, Line 115: Must allow only that TSEG pages can be marked executable.
How about: […]
Done
Until now it could be verified by FOSS developers on various Intel platforms
and no issues have been found.
I'd prefer to avoid using the word `verify` here, as there's no way to ensure x86_64 in CAR is fully […]
Done
To view, visit change 56017. To unsubscribe, or for help writing mail filters, visit settings.