Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42581 )
Change subject: src: don't select GENERATE_MP_TABLE if DRIVERS_GENERIC_IOAPIC is set
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42581/1/src/Kconfig
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/42581/1/src/Kconfig@670
PS1, Line 670: DRIVERS_GENERIC_IOAPIC
Wasn't sure about that one
Uh, I'd just clean up the whole option:
config GENERATE_MP_TABLE
bool "Generate an MP table"
default y
depends on HAVE_MP_TABLE
help
Generate an MP table (conforming to the Intel MultiProcessor
specification 1.4) for this board.
If unsure, say Y.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42581
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I785874df604e52feb06a2e67a29de1ffead29bfc
Gerrit-Change-Number: 42581
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 20 Jun 2020 10:56:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment