8 comments:
File src/mainboard/google/volteer/Kconfig:
This is a mainboard change. It should go in the next CL.
File src/soc/intel/tigerlake/early_tcss.c:
Patch Set #24, Line 3: #include <bootstate.h>
Why is this required?
Patch Set #24, Line 6: #include <ec/google/chromeec/ec.h>
Why is this required?
Patch Set #24, Line 102: while (--tries >= 0)
Just curious: Why are we trying 3 times? Is this operation known to fail for some reason?
File src/soc/intel/tigerlake/fsp_params.c:
What does DSK mean?
Why WEAK?
Patch Set #24, Line 378: vboot_recovery_mode_enabled
What about developer mode? Wouldn't you need this in developer mode as well?
File src/soc/intel/tigerlake/include/soc/early_tcss.h:
Patch Set #24, Line 130: mainboard_early_tcss_enable
What is the expectation from mainboard here? There should be a comment explaining the expectations.
To view, visit change 42079. To unsubscribe, or for help writing mail filters, visit settings.